Pawel Jakub Daw...
pjd@FreeBSD.org
|
|
|
|
Re: Some ZFS patches.
Posted:
Aug 21, 2006 2:55 PM
in response to: Guest
|
|
On Tue, Aug 22, 2006 at 07:46:21AM +1000, James C. McPherson wrote:
> Pawel Jakub Dawidek wrote:
> >Hi.
> >I've some ZFS patches, maybe you'd find them useful:
> > http://people.freebsd.org/~pjd/opensolaris/00.patch
> > http://people.freebsd.org/~pjd/opensolaris/01.patch
> > http://people.freebsd.org/~pjd/opensolaris/02.patch
> > http://people.freebsd.org/~pjd/opensolaris/03.patch
> > http://people.freebsd.org/~pjd/opensolaris/04.patch
> > http://people.freebsd.org/~pjd/opensolaris/05.patch
> > http://people.freebsd.org/~pjd/opensolaris/06.patch
> > http://people.freebsd.org/~pjd/opensolaris/07.patch
>
>
> Great. What problems do they solve?
I thought they are quite straightforward, but some comments will be in
place, I agree:
00.patch - missing new line character
01.patch - /dev/zfs open failure is not properly detected and will not
be reported properly (at least here)
02.patch - returning NULL here is wrong, as I will be read by the caller
as success (0)
03.patch - some pointers-integers confusion fixes
04.patch - those values are too big to be handled as 'int', at least
this is what gcc says
05.patch - switch() can work with 'int' and those values are too big
06.patch - signal arc_reclaim_thread, so we don't have to wait 1 second
before cv_timedwait() return
07.patch - there are plently of locks which are not initialized nor
destroyed and it seems it is not detected on Solaris
--
Pawel Jakub Dawidek http://www.wheel.pl
pjd at FreeBSD dot org http://www.FreeBSD.org
FreeBSD committer Am I Evil? Yes, I Am!
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.4 (FreeBSD)
iD8DBQFE6iwMForvXbEpPzQRAscsAJwO4LD1prjQudpEzb72yFNQz4dWhQCdE3q4
S6A9usonkgfLqgF9kJXtJxQ=
=RaHG
-----END PGP SIGNATURE-----
_______________________________________________
zfs-code mailing list
zfs-code at opensolaris dot org
http://opensolaris.org/mailman/listinfo/zfs-code
|
|
