|
Replies:
8
-
Last Post:
Jan 9, 2006 10:56 AM
by: meem
|
|
|
Posts:
198
From:
Shanghai
Registered:
6/14/05
|
|
|
|
Posts:
3,083
From:
US
Registered:
3/9/05
|
|
|
|
re: udp_impl.h missing on b27
Posted:
Jan 3, 2006 12:02 AM
in response to: taochen
|
|
> /usr/include/inet/ipclassifier.h needs "inet/udp_impl.h"
> http://cvs.opensolaris.org/source/xref/on/usr/src/uts/common/inet/ipclassifier.h#40
>
> but udp_impl.h doesn't exist on my system.
It exists, it just isn't shipped. This is intentional -- it contains
implementation details that do not constitute a public programming
interface. By not shipping it, we reduce the likelihood of software
accidentally becoming dependent on its contents.
In build 27, the putback for 6281836 introduced a dependency on udp_impl.h
from ipclassifier.h, hence the build problem you see. However, the
contents of ipclassifier.h also do not constitute a public programming
interface. What are you trying to build that depends on ipclassifier.h?
--
meem
_______________________________________________
networking-discuss mailing list
networking-discuss at opensolaris dot org
|
|
|
|
|
Posts:
198
From:
Shanghai
Registered:
6/14/05
|
|
|
|
Re: udp_impl.h missing on b27
Posted:
Jan 3, 2006 12:16 AM
in response to: meem
|
|
On 1/3/06, Peter Memishian <peter dot memishian at sun dot com> wrote:
> /usr/include/inet/ipclassifier.h needs "inet/udp_impl.h"
> http://cvs.opensolaris.org/source/xref/on/usr/src/uts/common/inet/ipclassifier.h#40
>
> but udp_impl.h doesn't exist on my system.
It exists, it just isn't shipped. This is intentional -- it contains
implementation details that do not constitute a public programming
interface. By not shipping it, we reduce the likelihood of software
accidentally becoming dependent on its contents.
In build 27, the putback for 6281836 introduced a dependency on udp_impl.h
from ipclassifier.h, hence the build problem you see. However, the
contents of
ipclassifier.h also do not constitute a public programming
interface. What are you trying to build that depends on ipclassifier.h?
--
meem
lsof:
ftp://lsof.itap.purdue.edu/pub/tools/unix/lsof/lsof_4.76.tar.gzMy build from S10 works fine on b27, except for a warning message on Solaris version. I just wanted to get rid of the warning message by rebuilding it for "
5.11". Sorry I just shutdown my system, can't provide more information until tomorrow. Anyone should be able to recreate though. I believe I used Studio 11. (You just need to add '5.11' in the ./Configure file to pass lsof configuration script.
There're other build errors but not network related.) Thanks, Tao
_______________________________________________
networking-discuss mailing list
networking-discuss at opensolaris dot org
|
|
|
|
|
Posts:
3,083
From:
US
Registered:
3/9/05
|
|
|
|
Re: udp_impl.h missing on b27
Posted:
Jan 3, 2006 12:46 AM
in response to: taochen
|
|
> lsof:
> ftp://lsof.itap.purdue.edu/pub/tools/unix/lsof/lsof_4.76.tar.gz
I should've guessed; while lsof is an incredibly useful utility, it is
public enemy #1 when it comes to grovelling around in incredibly unstable
implementation details.
Anyway, it looks like we can easily eliminate the dependency between
ipclassifier.h's and udp_impl.h -- here are the diffs:
------- ipclassifier.h -------
40d39
< #include <inet/u
181c180
< udp_t *conn_udp; /* struct udp_s *conn_udp; /* Pointer to the udp struct */
Thanks for bringing this to our attention; I will log a bug. While we
will resolve this issue, we may choose to fix this differently after
reviewing all the factors involved.
--
meem
_______________________________________________
networking-discuss mailing list
networking-discuss at opensolaris dot org
|
|
|
|
|
Posts:
198
From:
Shanghai
Registered:
6/14/05
|
|
|
|
Re: udp_impl.h missing on b27
Posted:
Jan 3, 2006 8:25 AM
in response to: meem
|
|
On 1/3/06, Peter Memishian < peter dot memishian at sun dot com> wrote:
------- ipclassifier.h -------
40d39
< #include <inet/udp_impl.h>
181c180
< & nbsp; udp_t *conn_udp; /* Pointer to the udp struct */
---
> struct udp_s *conn_udp; &nbs p; /* Pointer to the udp struct */
Thanks for bringing this to our attention; I will log a bug. While we
will resolve this issue, we may choose to fix this differently after
reviewing all the factors involved.
--
meem
Thanks for quick response and logging the bug! Tao
|
|
|
|
|
Posts:
3,083
From:
US
Registered:
3/9/05
|
|
|
|
Re: udp_impl.h missing on b27
Posted:
Jan 3, 2006 5:16 PM
in response to: taochen
|
|
> Thanks for quick response and logging the bug!
No problem; the CR is 6368593.
Since a few people were confused by my comment that <inet/u is
not shipped, I also put together a short blog entry that elaborates on
what I meant:
http://blogs.sun.com/roller/page/meem?entry=private_vs_secret
I hope this clarifies matters.
--
meem
_______________________________________________
networking-discuss mailing list
networking-discuss at opensolaris dot org
|
|
|
|
|
Posts:
2
From:
Registered:
11/23/05
|
|
|
|
Re: udp_impl.h missing on b27
Posted:
Jan 4, 2006 10:01 AM
in response to: meem
|
|
Along these lines (getting lsof to compile on OpenSolaris), version 2.183 of
/usr/include/sys/fs/ufs_inode.h added a "struct slot" that conflicts with
/usr/include/sys/fs/pc_dir.h, making it impossible to include both files.
Would you be willing to log a bug on this?
Thanks,
-Ben
|
|
|
|
|
Posts:
2
From:
Registered:
11/23/05
|
|
|
|
Re: udp_impl.h missing on b27
Posted:
Jan 4, 2006 12:56 PM
in response to: bhlewis
|
|
Never mind, it was already filed as 6349042.
Sorry!
-Ben
|
|
|
|
|
Posts:
3,083
From:
US
Registered:
3/9/05
|
|
|
|
re: Re: udp_impl.h missing on b27
Posted:
Jan 9, 2006 10:56 AM
in response to: bhlewis
|
|
> Along these lines (getting lsof to compile on OpenSolaris), version 2.183 of
> /usr/include/sys/fs/ufs_inode.h added a "struct slot" that conflicts with
> /usr/include/sys/fs/pc_dir.h, making it impossible to include both files.
>
> Would you be willing to log a bug on this?
This is already filed as 6349042.
--
meem
_______________________________________________
networking-discuss mailing list
networking-discuss at opensolaris dot org
|
|
|
|
|
