|
Replies:
9
-
Last Post:
Jul 23, 2008 12:18 AM
by: abhilash tg
|
|
|
abhilash tg
abhi.tg4u@gmail.com
|
|
|
|
Request for code review for bug 6618681
Posted:
Jul 8, 2008 12:15 AM
|
|
Hi,
I am submitting the fix for bug 6618681
The bug synopsis is
Bug ID 6618681 Synopsis Extension property agentdir description is given as domain directory instead of Node agent directory
State 1-Dispatched (Default State) Category:Subcategory suncluster:ha-s1as Keywords Reported Against 3.2_fcs Duplicate Of Introduced In Commit to Fix
Fixed In Release Fixed Related Bugs Submit Date 18-OCT-2007 Last Update Date 18-OCT-2007 Description
Param name: Agentdir
Extension: True Per-node: False Description: The complete Path to the Domain Directory Tunability: When disabled
Type: String Min length: <Unset> Max length: <Unset> Default: <NULL>
Work Around
N/A
My sponsor has done the testing.
regards Abhilash
_______________________________________________
ha-clusters-discuss mailing list
ha-clusters-discuss at opensolaris dot org
http://mail.opensolaris.org/mailman/listinfo/ha-clusters-discuss
|
|
|
|
|
|
|
Re: Request for code review for bug 6618681
Posted:
Jul 8, 2008 12:20 AM
in response to: abhilash tg
|
|
|
|
Abilash,
I am not able to see the code change. Have you attached the right file?
Best Regards,
Madhan Kumar
abhilash tg wrote:
Hi,
I am submitting the fix for bug 6618681
The bug synopsis is
Bug ID 6618681
Synopsis Extension property agentdir description is given as
domain directory instead of Node agent directory
State 1-Dispatched (Default State)
Category:Subcategory suncluster:ha-s1as
Keywords
Reported Against 3.2_fcs
Duplicate Of
Introduced In
Commit to Fix
Fixed In
Release Fixed
Related Bugs
Submit Date 18-OCT-2007
Last Update Date 18-OCT-2007
Description
Param name: Agentdir
Extension: True
Per-node: False
Description: The complete Path to
the Domain Directory
Tunability: When disabled
Type: String
Min length: <Unset>
Max length: <Unset>
Default: <NULL>
Work Around
N/A
My sponsor has done the testing.
regards
Abhilash
<pre wrap="">
<hr size="4" width="90%">
_______________________________________________
ha-clusters-discuss mailing list
ha-clusters-discuss at opensolaris dot org
http://mail.opensolaris.org/mailman/listinfo/ha-clusters-discuss
</pre>
_______________________________________________
ha-clusters-discuss mailing list
ha-clusters-discuss at opensolaris dot org
http://mail.opensolaris.org/mailman/listinfo/ha-clusters-discuss
|
|
|
|
abhilash tg
abhi.tg4u@gmail.com
|
|
|
|
Request for code review for bug 6618681
Posted:
Jul 8, 2008 4:55 AM
in response to: abhilash tg
|
|
|
|
Hi,
I am submitting the fix for bug 6618681
The bug synopsis is
Bug ID 6618681 Synopsis Extension property agentdir description is given as domain directory instead of Node agent directory
State 1-Dispatched (Default State) Category:Subcategory suncluster:ha-s1as Keywords Reported Against 3.2_fcs Duplicate Of Introduced In Commit to Fix
Fixed In Release Fixed Related Bugs Submit Date 18-OCT-2007 Last Update Date 18-OCT-2007 Description
Param name: Agentdir
Extension: True Per-node: False Description: The complete Path to the Domain Directory Tunability: When disabled
Type: String Min length: <Unset> Max length: <Unset> Default: <NULL>
Work Around
N/A
My sponsor has done the testing.
regards Abhilash
_______________________________________________
ha-clusters-discuss mailing list
ha-clusters-discuss at opensolaris dot org
http://mail.opensolaris.org/mailman/listinfo/ha-clusters-discuss
|
|
|
|
Posts:
46
From:
Registered:
7/11/07
|
|
|
|
Re: Request for code review for bug 6618681
Posted:
Jul 8, 2008 5:14 AM
in response to: abhilash tg
|
|
Hi,
The fix that Abhilash has done is in the RTR file
usr/src/cmd/ha-services/cmd/jsas-na/SUNW.jsas-na in the "DESCIPTION"
field of the extension property Agentdir.
{
PROPERTY = Agentdir;
EXTENSION;
STRING;
DEFAULT = "";
TUNABLE = WHEN_DISABLED;
DESCRIPTION = "The complete Path to the Node Agent Directory ";
} "
I have done the required testing for this on Glassfish on Cluster
Express build_22b. Created/Started DAS and Node Agent resources.
Here is the output:
scrgadm -pvvv | grep -i AgentDir
(SUNW.jsas-na:3.2) Res Type param name: Agentdir
(SUNW.jsas-na:3.2:Agentdir) Res Type param extension: True
(SUNW.jsas-na:3.2:Agentdir) Res Type param per-node: False
(SUNW.jsas-na:3.2:Agentdir) Res Type param description: The
complete Path to the Node Agent Directory
(SUNW.jsas-na:3.2:Agentdir) Res Type param tunability: When
disabled
(SUNW.jsas-na:3.2:Agentdir) Res Type param type: String
(SUNW.jsas-na:3.2:Agentdir) Res Type param min length:
<unset>
(SUNW.jsas-na:3.2:Agentdir) Res Type param max length:
<unset>
(SUNW.jsas-na:3.2:Agentdir) Res Type param default: <NULL>
(rg:na-rs) Res property name: Agentdir
(rg:na-rs:Agentdir) Res property class: extension
(rg:na-rs:Agentdir) Res property description: The complete
Path to the Node Agent Directory
(rg:na-rs:Agentdir) Res property pernode: False
(rg:na-rs:Agentdir) Res property type: string
(rg:na-rs:Agentdir) Res property value:
/glassfish/glassfish/nodeagents
Thanks,
Swathi
abhilash tg wrote:
Hi,
I am submitting the fix for bug 6618681
The bug synopsis is
Bug ID 6618681
Synopsis Extension property agentdir description is given as
domain directory instead of Node agent directory
State 1-Dispatched (Default State)
Category:Subcategory suncluster:ha-s1as
Keywords
Reported Against 3.2_fcs
Duplicate Of
Introduced In
Commit to Fix
Fixed In
Release Fixed
Related Bugs
Submit Date 18-OCT-2007
Last Update Date 18-OCT-2007
Description
Param name: Agentdir
Extension: True
Per-node: False
Description: The complete Path to
the Domain Directory
Tunability: When disabled
Type: String
Min length: <Unset>
Max length: <Unset>
Default: <NULL>
Work Around
N/A
My sponsor has done the testing.
regards
Abhilash
_______________________________________________
ha-clusters-discuss mailing list
ha-clusters-discuss at opensolaris dot org
http://mail.opensolaris.org/mailman/listinfo/ha-clusters-discuss
|
|
|
|
Posts:
46
From:
Registered:
7/11/07
|
|
|
|
Re: Request for code review for bug 6618681
Posted:
Jul 21, 2008 3:40 AM
in response to: sdevulap
|
|
Hi,
On behalf of Abhilash T G, I have posted the webrev on opensolaris.org.
@ http://cr.opensolaris.org/~sdevulap/ha-jsas_CR6618681/
for better readability.
Please review the same and let me know your comments.
Thanks,
Swathi
Swathi Devulapalli wrote:
<meta content="text/html;charset=ISO-8859-1" http-equiv="Content-Type">
Hi,
The fix that Abhilash has done is in the RTR file
usr/src/cmd/ha-services/cmd/jsas-na/SUNW.jsas-na in the "DESCIPTION"
field of the extension property Agentdir.
{
PROPERTY = Agentdir;
EXTENSION;
STRING;
DEFAULT = "";
TUNABLE = WHEN_DISABLED;
DESCRIPTION = "The complete Path to the Node Agent Directory ";
} "
I have done the required testing for this on Glassfish on Cluster
Express build_22b. Created/Started DAS and Node Agent resources.
Here is the output:
scrgadm -pvvv | grep -i AgentDir
(SUNW.jsas-na:3.2) Res Type param name: Agentdir
(SUNW.jsas-na:3.2:Agentdir) Res Type param extension: True
(SUNW.jsas-na:3.2:Agentdir) Res Type param per-node: False
(SUNW.jsas-na:3.2:Agentdir) Res Type param description: The
complete Path to the Node Agent Directory
(SUNW.jsas-na:3.2:Agentdir) Res Type param tunability: When
disabled
(SUNW.jsas-na:3.2:Agentdir) Res Type param type: String
(SUNW.jsas-na:3.2:Agentdir) Res Type param min length:
<unset>
(SUNW.jsas-na:3.2:Agentdir) Res Type param max length:
<unset>
(SUNW.jsas-na:3.2:Agentdir) Res Type param default: <NULL>
(rg:na-rs) Res property name: Agentdir
(rg:na-rs:Agentdir) Res property class: extension
(rg:na-rs:Agentdir) Res property description: The complete
Path to the Node Agent Directory
(rg:na-rs:Agentdir) Res property pernode: False
(rg:na-rs:Agentdir) Res property type: string
(rg:na-rs:Agentdir) Res property value:
/glassfish/glassfish/nodeagents
Thanks,
Swathi
abhilash tg wrote:
Hi,
I am submitting the fix for bug 6618681
The bug synopsis is
Bug ID 6618681
Synopsis Extension property agentdir description is given as
domain directory instead of Node agent directory
State 1-Dispatched (Default State)
Category:Subcategory suncluster:ha-s1as
Keywords
Reported Against 3.2_fcs
Duplicate Of
Introduced In
Commit to Fix
Fixed In
Release Fixed
Related Bugs
Submit Date 18-OCT-2007
Last Update Date 18-OCT-2007
Description
Param name: Agentdir
Extension: True
Per-node: False
Description: The complete Path to
the Domain Directory
Tunability: When disabled
Type: String
Min length: <Unset>
Max length: <Unset>
Default: <NULL>
Work Around
N/A
My sponsor has done the testing.
regards
Abhilash
<pre wrap="">
<hr size="4" width="90%">
_______________________________________________
ha-clusters-discuss mailing list
ha-clusters-discuss at opensolaris dot org
http://mail.opensolaris.org/mailman/listinfo/ha-clusters-discuss
</pre>
_______________________________________________
ha-clusters-discuss mailing list
ha-clusters-discuss at opensolaris dot org
http://mail.opensolaris.org/mailman/listinfo/ha-clusters-discuss
|
|
|
|
Posts:
137
From:
GB
Registered:
6/1/07
|
|
|
|
Re: Request for code review for bug 6618681
Posted:
Jul 21, 2008 3:53 AM
in response to: sdevulap
|
|
Hi Swathi/Abhilash,
Looks good.
Regards Neil
On 21 Jul 2008, at 11:40, Swathi Devulapalli wrote: Hi, On behalf of Abhilash T G, I have posted the webrev on opensolaris.org. @ http://cr.opensolaris.org/~sdevulap/ha-jsas_CR6618681/ for better readability. Please review the same and let me know your comments. Thanks, Swathi Swathi Devulapalli wrote: Hi, The fix that Abhilash has done is in the RTR file usr/src/cmd/ha-services/cmd/jsas-na/SUNW.jsas-na in the "DESCIPTION" field of the extension property Agentdir. { PROPERTY = Agentdir; EXTENSION; STRING; DEFAULT = ""; TUNABLE = WHEN_DISABLED; DESCRIPTION = "The complete Path to the Node Agent Directory "; } " I have done the required testing for this on Glassfish on Cluster Express build_22b. Created/Started DAS and Node Agent resources. Here is the output: scrgadm -pvvv | grep -i AgentDir (SUNW.jsas-na:3.2) Res Type param name: Agentdir (SUNW.jsas-na:3.2:Agentdir) Res Type param extension: True (SUNW.jsas-na:3.2:Agentdir) Res Type param per-node: False (SUNW.jsas-na:3.2:Agentdir) Res Type param description: The complete Path to the Node Agent Directory (SUNW.jsas-na:3.2:Agentdir) Res Type param tunability: When disabled (SUNW.jsas-na:3.2:Agentdir) Res Type param type: String (SUNW.jsas-na:3.2:Agentdir) Res Type param min length: <unset> (SUNW.jsas-na:3.2:Agentdir) Res Type param max length: <unset> (SUNW.jsas-na:3.2:Agentdir) Res Type param default: <NULL> (rg:na-rs) Res property name: Agentdir (rg:na-rs:Agentdir) Res property class: extension (rg:na-rs:Agentdir) Res property description: The complete Path to the Node Agent Directory (rg:na-rs:Agentdir) Res property pernode: False (rg:na-rs:Agentdir) Res property type: string (rg:na-rs:Agentdir) Res property value: /glassfish/glassfish/nodeagents Thanks, Swathi abhilash tg wrote: Hi, I am submitting the fix for bug 6618681 The bug synopsis is Bug ID 6618681 Synopsis Extension property agentdir description is given as domain directory instead of Node agent directory State 1-Dispatched (Default State) Category:Subcategory suncluster:ha-s1as Keywords Reported Against 3.2_fcs Duplicate Of Introduced In Commit to Fix Fixed In Release Fixed Related Bugs Submit Date 18-OCT-2007 Last Update Date 18-OCT-2007 Description Param name: Agentdir Extension: True Per-node: False Description: The complete Path to the Domain Directory Tunability: When disabled Type: String Min length: <Unset> Max length: <Unset> Default: <NULL> Work Around N/A My sponsor has done the testing. regards Abhilash <pre wrap=""><hr size="4" width="90%">
_______________________________________________
ha-clusters-discuss mailing list
ha-clusters-discuss at opensolaris dot org
http://mail.opensolaris.org/mailman/listinfo/ha-clusters-discuss
</pre> _______________________________________________ ha-clusters-discuss mailing list ha-clusters-discuss at opensolaris dot org http://mail.opensolaris.org/mailman/listinfo/ha-clusters-discuss
_______________________________________________
ha-clusters-discuss mailing list
ha-clusters-discuss at opensolaris dot org
http://mail.opensolaris.org/mailman/listinfo/ha-clusters-discuss
|
|
|
|
Posts:
122
From:
DE
Registered:
5/30/07
|
|
|
|
Re: Request for code review for bug 6618681
Posted:
Jul 21, 2008 4:43 AM
in response to: sdevulap
|
|
Hi Swathi and Abhilash,
it looks good.
Detlef
Swathi Devulapalli wrote: > Hi, > > On behalf of Abhilash T G, I have posted the webrev on opensolaris.org. > @ http://cr.opensolaris.org/~sdevulap/ha-jsas_CR6618681/ > for better readability. > > Please review the same and let me know your comments. > > Thanks, > Swathi > > Swathi Devulapalli wrote: >> Hi, >> >> The fix that Abhilash has done is in the RTR file >> usr/src/cmd/ha-services/cmd/jsas-na/SUNW.jsas-na in the "DESCIPTION" >> field of the extension property Agentdir. >> >> { >> PROPERTY = Agentdir; >> EXTENSION; >> STRING; >> DEFAULT = ""; >> TUNABLE = WHEN_DISABLED; >> DESCRIPTION = "The complete Path to the Node Agent Directory "; >> } " >> >> I have done the required testing for this on Glassfish on Cluster >> Express build_22b. Created/Started DAS and Node Agent resources. >> Here is the output: >> scrgadm -pvvv | grep -i AgentDir >> (SUNW.jsas-na:3.2) Res Type param name: Agentdir >> (SUNW.jsas-na:3.2:Agentdir) Res Type param extension: True >> (SUNW.jsas-na:3.2:Agentdir) Res Type param per-node: False >> (SUNW.jsas-na:3.2:Agentdir) Res Type param description: The >> complete Path to the Node Agent Directory >> (SUNW.jsas-na:3.2:Agentdir) Res Type param tunability: When >> disabled >> (SUNW.jsas-na:3.2:Agentdir) Res Type param type: String >> (SUNW.jsas-na:3.2:Agentdir) Res Type param min length: <unset> >> (SUNW.jsas-na:3.2:Agentdir) Res Type param max length: <unset> >> (SUNW.jsas-na:3.2:Agentdir) Res Type param default: <NULL> >> (rg:na-rs) Res property name: Agentdir >> (rg:na-rs:Agentdir) Res property class: extension >> (rg:na-rs:Agentdir) Res property description: The complete Path >> to the Node Agent Directory >> (rg:na-rs:Agentdir) Res property pernode: False >> (rg:na-rs:Agentdir) Res property type: string >> (rg:na-rs:Agentdir) Res property value: >> /glassfish/glassfish/nodeagents >> >> Thanks, >> Swathi >> >> >> abhilash tg wrote: >>> Hi, >>> >>> >>> I am submitting the fix for bug 6618681 >>> >>> The bug synopsis is >>> >>> Bug ID 6618681 >>> Synopsis Extension property agentdir description is given as >>> domain directory instead of Node agent directory >>> State 1-Dispatched (Default State) >>> Category:Subcategory suncluster:ha-s1as >>> Keywords >>> Reported Against 3.2_fcs >>> Duplicate Of >>> Introduced In >>> Commit to Fix >>> Fixed In >>> Release Fixed >>> Related Bugs >>> Submit Date 18-OCT-2007 >>> Last Update Date 18-OCT-2007 >>> Description >>> >>> Param name: Agentdir >>> Extension: True >>> Per-node: False >>> Description: The complete Path >>> to the Domain Directory >>> Tunability: When disabled >>> Type: String >>> Min length: <Unset> >>> Max length: <Unset> >>> Default: <NULL> >>> >>> Work Around >>> >>> N/A >>> >>> >>> My sponsor has done the testing. >>> >>> regards >>> Abhilash >>> >> ------------------------------------------------------------------------ >> >> _______________________________________________ >> ha-clusters-discuss mailing list >> ha-clusters-discuss at opensolaris dot org >> http://mail.opensolaris.org/mailman/listinfo/ha-clusters-discuss >> > ------------------------------------------------------------------------ > > _______________________________________________ > ha-clusters-discuss mailing list > ha-clusters-discuss at opensolaris dot org > http://mail.opensolaris.org/mailman/listinfo/ha-clusters-discuss >
--
***************************************************************************** Detlef Ulherr Staff Engineer Tel: (++49 6103) 752-248 Availability Engineering Fax: (++49 6103) 752-167 Sun Microsystems GmbH Amperestraße 6 mailto:detlef dot ulherr at sun dot com 63225 Langen http://www.sun.de/ *****************************************************************************
Sitz der Gesellschaft: Sun Microsystems GmbH, Sonnenallee 1, D-85551 Kirchheim-Heimstetten Amtsgericht Muenchen: HRB 161028 Geschaeftsfuehrer: Thomas Schroeder, Wolfgang Engels, Dr. Roland Boemer Vorsitzender des Aufsichtsrates: Martin Haering
*****************************************************************************
_______________________________________________ ha-clusters-discuss mailing list ha-clusters-discuss at opensolaris dot org http://mail.opensolaris.org/mailman/listinfo/ha-clusters-discuss
|
|
|
|
Posts:
46
From:
Registered:
7/11/07
|
|
|
|
Re: Request for code review for bug 6618681
Posted:
Jul 22, 2008 11:21 PM
in response to: ulherr
|
|
Hi,
Thank you, Marty, Neil and Detlef for taking time to review the code.
Regards,
Swathi
Detlef Ulherr wrote:
<pre wrap="">Hi Swathi and Abhilash,
it looks good.
Detlef
Swathi Devulapalli wrote:
</pre>
<pre wrap="">Hi,
On behalf of Abhilash T G, I have posted the webrev on opensolaris.org.
@ http://cr.opensolaris.org/~sdevulap/ha-jsas_CR6618681/
for better readability.
Please review the same and let me know your comments.
Thanks,
Swathi
Swathi Devulapalli wrote:
</pre>
<pre wrap="">Hi,
The fix that Abhilash has done is in the RTR file
usr/src/cmd/ha-services/cmd/jsas-na/SUNW.jsas-na in the "DESCIPTION"
field of the extension property Agentdir.
{
PROPERTY = Agentdir;
EXTENSION;
STRING;
DEFAULT = "";
TUNABLE = WHEN_DISABLED;
DESCRIPTION = "The complete Path to the Node Agent Directory ";
} "
I have done the required testing for this on Glassfish on Cluster
Express build_22b. Created/Started DAS and Node Agent resources.
Here is the output:
scrgadm -pvvv | grep -i AgentDir
(SUNW.jsas-na:3.2) Res Type param name: Agentdir
(SUNW.jsas-na:3.2:Agentdir) Res Type param extension: True
(SUNW.jsas-na:3.2:Agentdir) Res Type param per-node: False
(SUNW.jsas-na:3.2:Agentdir) Res Type param description: The
complete Path to the Node Agent Directory
(SUNW.jsas-na:3.2:Agentdir) Res Type param tunability: When
disabled
(SUNW.jsas-na:3.2:Agentdir) Res Type param type: String
(SUNW.jsas-na:3.2:Agentdir) Res Type param min length: <unset>
(SUNW.jsas-na:3.2:Agentdir) Res Type param max length: <unset>
(SUNW.jsas-na:3.2:Agentdir) Res Type param default: <NULL>
(rg:na-rs) Res property name: Agentdir
(rg:na-rs:Agentdir) Res property class: extension
(rg:na-rs:Agentdir) Res property description: The complete Path
to the Node Agent Directory
(rg:na-rs:Agentdir) Res property pernode: False
(rg:na-rs:Agentdir) Res property type: string
(rg:na-rs:Agentdir) Res property value:
/glassfish/glassfish/nodeagents
Thanks,
Swathi
abhilash tg wrote:
</pre>
<pre wrap="">Hi,
I am submitting the fix for bug 6618681
The bug synopsis is
Bug ID 6618681
Synopsis Extension property agentdir description is given as
domain directory instead of Node agent directory
State 1-Dispatched (Default State)
Category:Subcategory suncluster:ha-s1as
Keywords
Reported Against 3.2_fcs
Duplicate Of
Introduced In
Commit to Fix
Fixed In
Release Fixed
Related Bugs
Submit Date 18-OCT-2007
Last Update Date 18-OCT-2007
Description
Param name: Agentdir
Extension: True
Per-node: False
Description: The complete Path
to the Domain Directory
Tunability: When disabled
Type: String
Min length: <Unset>
Max length: <Unset>
Default: <NULL>
Work Around
N/A
My sponsor has done the testing.
regards
Abhilash
</pre>
<pre wrap="">-------------------------------------------------------------------- ----
_______________________________________________
ha-clusters-discuss mailing list
ha-clusters-discuss at opensolaris dot org
http://mail.opensolaris.org/mailman/listinfo/ha-clusters-discuss
</pre>
<pre wrap="">-------------------------------------------------------------------- ----
_______________________________________________
ha-clusters-discuss mailing list
ha-clusters-discuss at opensolaris dot org
http://mail.opensolaris.org/mailman/listinfo/ha-clusters-discuss
</pre>
<pre wrap=""><!---->
</pre>
_______________________________________________
ha-clusters-discuss mailing list
ha-clusters-discuss at opensolaris dot org
http://mail.opensolaris.org/mailman/listinfo/ha-clusters-discuss
|
|
|
|
Posts:
241
From:
Registered:
5/29/07
|
|
|
|
Re: Request for code review for bug 6618681
Posted:
Jul 22, 2008 11:27 PM
in response to: sdevulap
|
|
Hi Abhilash, Swathi et al,
sorry for the late review, and thanks for providing the webrev.
I am fine with the changes.
Greets Thorsten
Swathi Devulapalli wrote: > Hi, > > Thank you, Marty, Neil and Detlef for taking time to review the code. > > Regards, > Swathi > > Detlef Ulherr wrote: >> Hi Swathi and Abhilash, >> >> it looks good. >> >> Detlef >> >> Swathi Devulapalli wrote: >> >>> Hi, >>> >>> On behalf of Abhilash T G, I have posted the webrev on opensolaris.org. >>> @ http://cr.opensolaris.org/~sdevulap/ha-jsas_CR6618681/ >>> for better readability. >>> >>> Please review the same and let me know your comments. >>> >>> Thanks, >>> Swathi >>> >>> Swathi Devulapalli wrote: >>> >>>> Hi, >>>> >>>> The fix that Abhilash has done is in the RTR file >>>> usr/src/cmd/ha-services/cmd/jsas-na/SUNW.jsas-na in the "DESCIPTION" >>>> field of the extension property Agentdir. >>>> >>>> { >>>> PROPERTY = Agentdir; >>>> EXTENSION; >>>> STRING; >>>> DEFAULT = ""; >>>> TUNABLE = WHEN_DISABLED; >>>> DESCRIPTION = "The complete Path to the Node Agent Directory "; >>>> } " >>>> >>>> I have done the required testing for this on Glassfish on Cluster >>>> Express build_22b. Created/Started DAS and Node Agent resources. >>>> Here is the output: >>>> scrgadm -pvvv | grep -i AgentDir >>>> (SUNW.jsas-na:3.2) Res Type param name: Agentdir >>>> (SUNW.jsas-na:3.2:Agentdir) Res Type param extension: True >>>> (SUNW.jsas-na:3.2:Agentdir) Res Type param per-node: False >>>> (SUNW.jsas-na:3.2:Agentdir) Res Type param description: The >>>> complete Path to the Node Agent Directory >>>> (SUNW.jsas-na:3.2:Agentdir) Res Type param tunability: When >>>> disabled >>>> (SUNW.jsas-na:3.2:Agentdir) Res Type param type: String >>>> (SUNW.jsas-na:3.2:Agentdir) Res Type param min length: <unset> >>>> (SUNW.jsas-na:3.2:Agentdir) Res Type param max length: <unset> >>>> (SUNW.jsas-na:3.2:Agentdir) Res Type param default: <NULL> >>>> (rg:na-rs) Res property name: Agentdir >>>> (rg:na-rs:Agentdir) Res property class: extension >>>> (rg:na-rs:Agentdir) Res property description: The complete Path >>>> to the Node Agent Directory >>>> (rg:na-rs:Agentdir) Res property pernode: False >>>> (rg:na-rs:Agentdir) Res property type: string >>>> (rg:na-rs:Agentdir) Res property value: >>>> /glassfish/glassfish/nodeagents >>>> >>>> Thanks, >>>> Swathi >>>> >>>> >>>> abhilash tg wrote: >>>> >>>>> Hi, >>>>> >>>>> >>>>> I am submitting the fix for bug 6618681 >>>>> >>>>> The bug synopsis is >>>>> >>>>> Bug ID 6618681 >>>>> Synopsis Extension property agentdir description is given as >>>>> domain directory instead of Node agent directory >>>>> State 1-Dispatched (Default State) >>>>> Category:Subcategory suncluster:ha-s1as >>>>> Keywords >>>>> Reported Against 3.2_fcs >>>>> Duplicate Of >>>>> Introduced In >>>>> Commit to Fix >>>>> Fixed In >>>>> Release Fixed >>>>> Related Bugs >>>>> Submit Date 18-OCT-2007 >>>>> Last Update Date 18-OCT-2007 >>>>> Description >>>>> >>>>> Param name: Agentdir >>>>> Extension: True >>>>> Per-node: False >>>>> Description: The complete Path >>>>> to the Domain Directory >>>>> Tunability: When disabled >>>>> Type: String >>>>> Min length: <Unset> >>>>> Max length: <Unset> >>>>> Default: <NULL> >>>>> >>>>> Work Around >>>>> >>>>> N/A >>>>> >>>>> >>>>> My sponsor has done the testing. >>>>> >>>>> regards >>>>> Abhilash
-- ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Sitz der Gesellschaft: Sun Microsystems GmbH, Sonnenallee 1, D-85551 Kirchheim-Heimstetten Amtsgericht Muenchen: HRB 161028 Geschaeftsfuehrer: Thomas Schroeder, Wolfgang Engels, Dr. Roland Boemer Vorsitzender des Aufsichtsrates: Martin Haering ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ _______________________________________________ ha-clusters-discuss mailing list ha-clusters-discuss at opensolaris dot org http://mail.opensolaris.org/mailman/listinfo/ha-clusters-discuss
|
|
|
|
abhilash tg
abhi.tg4u@gmail.com
|
|
|
|
Re: Request for code review for bug 6618681
Posted:
Jul 23, 2008 12:18 AM
in response to: frueauf
|
|
Hi, Thank you all for your support and patience for helping me. regards Abhilash 2008/7/23 Thorsten Frueauf < Thorsten dot Frueauf at sun dot com>:
Hi Abhilash, Swathi et al,
sorry for the late review, and thanks for providing the webrev.
I am fine with the changes.
Greets
Thorsten
Swathi Devulapalli wrote:
Hi,
Thank you, Marty, Neil and Detlef for taking time to review the code.
Regards,
Swathi
Detlef Ulherr wrote:
Hi Swathi and Abhilash,
it looks good.
Detlef
Swathi Devulapalli wrote:
Hi,
On behalf of Abhilash T G, I have posted the webrev on opensolaris.org.
@ http://cr.opensolaris.org/~sdevulap/ha-jsas_CR6618681/
for better readability.
Please review the same and let me know your comments.
Thanks,
Swathi
Swathi Devulapalli wrote:
Hi,
The fix that Abhilash has done is in the RTR file
usr/src/cmd/ha-services/cmd/jsas-na/SUNW.jsas-na in the "DESCIPTION"
field of the extension property Agentdir.
{
PROPERTY = Agentdir;
EXTENSION;
STRING;
DEFAULT = "";
TUNABLE = WHEN_DISABLED;
DESCRIPTION = "The complete Path to the Node Agent Directory ";
} "
I have done the required testing for this on Glassfish on Cluster
Express build_22b. Created/Started DAS and Node Agent resources.
Here is the output:
scrgadm -pvvv | grep -i AgentDir
(SUNW.jsas-na:3.2) Res Type param name: Agentdir
(SUNW.jsas-na:3.2:Agentdir) Res Type param extension: True
(SUNW.jsas-na:3.2:Agentdir) Res Type param per-node: False
(SUNW.jsas-na:3.2:Agentdir) Res Type param description: The
complete Path to the Node Agent Directory
(SUNW.jsas-na:3.2:Agentdir) Res Type param tunability: When
disabled
(SUNW.jsas-na:3.2:Agentdir) Res Type param type: String
(SUNW.jsas-na:3.2:Agentdir) Res Type param min length: <unset>
(SUNW.jsas-na:3.2:Agentdir) Res Type param max length: <unset>
(SUNW.jsas-na:3.2:Agentdir) Res Type param default: <NULL>
(rg:na-rs) Res property name: Agentdir
(rg:na-rs:Agentdir) Res property class: extension
(rg:na-rs:Agentdir) Res property description: The complete Path
to the Node Agent Directory
(rg:na-rs:Agentdir) Res property pernode: False
(rg:na-rs:Agentdir) Res property type: string
(rg:na-rs:Agentdir) Res property value:
/glassfish/glassfish/nodeagents
Thanks,
Swathi
abhilash tg wrote:
Hi,
I am submitting the fix for bug 6618681
The bug synopsis is
Bug ID 6618681
Synopsis Extension property agentdir description is given as
domain directory instead of Node agent directory
State 1-Dispatched (Default State)
Category:Subcategory suncluster:ha-s1as
Keywords Reported Against 3.2_fcs
Duplicate Of Introduced In Commit to Fix Fixed In Release Fixed Related Bugs Submit Date 18-OCT-2007
Last Update Date 18-OCT-2007
Description
Param name: Agentdir
Extension: True
Per-node: False
Description: The complete Path
to the Domain Directory
Tunability: When disabled
Type: String
Min length: <Unset>
Max length: <Unset>
Default: <NULL>
Work Around
N/A
My sponsor has done the testing.
regards
Abhilash
--
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Sitz der Gesellschaft:
Sun Microsystems GmbH, Sonnenallee 1, D-85551 Kirchheim-Heimstetten
Amtsgericht Muenchen: HRB 161028
Geschaeftsfuehrer: Thomas Schroeder, Wolfgang Engels, Dr. Roland Boemer
Vorsitzender des Aufsichtsrates: Martin Haering
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
_______________________________________________
ha-clusters-discuss mailing list
ha-clusters-discuss at opensolaris dot org
http://mail.opensolaris.org/mailman/listinfo/ha-clusters-discuss
|
|
|
|
|