OpenSolaris

Discussions Communities Projects Download Source Browser

Home » OpenSolaris Forums » ha-clusters » discuss

Thread: [ha-clusters-discuss] Code review for bug 4616225 fix

Welcome, Guest Help
Login Login
Guest Settings Guest Settings
Reply to this Thread Reply to this Thread Search Forum Search Forum Back to Thread List Back to Thread List

Permlink Replies: 3 - Last Post: Jan 15, 2009 12:32 AM by: lalith
lalith

Posts: 11
From: IN

Registered: 12/2/08
[ha-clusters-discuss] Code review for bug 4616225 fix
Posted: Jan 14, 2009 7:19 PM

  Click to reply to this thread Reply

Hello everyone,

I recently fixed a very trivial bug (Bug ID 4616225). My sponsor for the same is Tirthankar Das.

The webrev can be viewed at:

http://cr.opensolaris.org/~tirth/webrev_4616225/

I kindly request all of you to review this change and let us know in case there are any complaints within two days so that the changes can be putback ASAP.

Thanks and regards,
Lalith



--
Lalith Suresh
Department of Computer Engineering
Malaviya National Institute of Technology, Jaipur
+91-9982190365 , lalithsuresh.wordpress.com
_______________________________________________ ha-clusters-discuss mailing list ha-clusters-discuss at opensolaris dot org http://mail.opensolaris.org/mailman/listinfo/ha-clusters-discuss


frueauf

Posts: 241
From:

Registered: 5/29/07
Re: [ha-clusters-discuss] Code review for bug 4616225 fix
Posted: Jan 14, 2009 11:16 PM   in response to: lalith

  Click to reply to this thread Reply

Hi Lalith et al,


- usr/src/cmd/ql/scripts/bootcluster.sh

* line 24, the copyright needs to be set to 2009

Otherwise the changes look fine to me.

Thanks for the contribution!

Greets
Thorsten

Lalith Suresh wrote:
> Hello everyone,
>
> I recently fixed a very trivial bug (Bug ID 4616225). My sponsor for the
> same is Tirthankar Das.
>
> The webrev can be viewed at:
>
> http://cr.opensolaris.org/~tirth/webrev_4616225/
>
> I kindly request all of you to review this change and let us know in
> case there are any complaints within two days so that the changes can be
> putback ASAP.
>
> Thanks and regards,
> Lalith

--
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Sitz der Gesellschaft:
Sun Microsystems GmbH, Sonnenallee 1, D-85551 Kirchheim-Heimstetten
Amtsgericht Muenchen: HRB 161028
Geschaeftsfuehrer: Thomas Schroeder, Wolfgang Engels, Dr. Roland Boemer
Vorsitzender des Aufsichtsrates: Martin Haering
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
_______________________________________________
ha-clusters-discuss mailing list
ha-clusters-discuss at opensolaris dot org
http://mail.opensolaris.org/mailman/listinfo/ha-clusters-discuss


ulherr

Posts: 122
From: DE

Registered: 5/30/07
Re: [ha-clusters-discuss] Code review for bug 4616225 fix
Posted: Jan 15, 2009 12:13 AM   in response to: frueauf

  Click to reply to this thread Reply

Hi Lalith,

Nothing to add, so fix the copyright and go ahead.

Cheers
Detlef

Thorsten Frueauf wrote:
> Hi Lalith et al,
>
>
> - usr/src/cmd/ql/scripts/bootcluster.sh
>
> * line 24, the copyright needs to be set to 2009
>
> Otherwise the changes look fine to me.
>
> Thanks for the contribution!
>
> Greets
> Thorsten
>
> Lalith Suresh wrote:
>
>> Hello everyone,
>>
>> I recently fixed a very trivial bug (Bug ID 4616225). My sponsor for the
>> same is Tirthankar Das.
>>
>> The webrev can be viewed at:
>>
>> http://cr.opensolaris.org/~tirth/webrev_4616225/
>>
>> I kindly request all of you to review this change and let us know in
>> case there are any complaints within two days so that the changes can be
>> putback ASAP.
>>
>> Thanks and regards,
>> Lalith
>>
>
>


--

*****************************************************************************
Detlef Ulherr
Staff Engineer Tel: (++49 6103) 752-248
Availability Engineering Fax: (++49 6103) 752-167
Sun Microsystems GmbH
Amperestr. 6 mailto:detlef dot ulherr at sun dot com
63225 Langen http://www.sun.de/
*****************************************************************************

Sitz der Gesellschaft: Sun Microsystems GmbH, Sonnenallee 1, D-85551
Kirchheim-Heimstetten
Amtsgericht Muenchen: HRB 161028
Geschaeftsfuehrer: Thomas Schroeder, Wolfgang Engels, Dr. Roland Boemer
Vorsitzender des Aufsichtsrates: Martin Haering

*****************************************************************************


_______________________________________________
ha-clusters-discuss mailing list
ha-clusters-discuss at opensolaris dot org
http://mail.opensolaris.org/mailman/listinfo/ha-clusters-discuss


lalith

Posts: 11
From: IN

Registered: 12/2/08
Re: [ha-clusters-discuss] Code review for bug 4616225 fix
Posted: Jan 15, 2009 12:32 AM   in response to: ulherr

  Click to reply to this thread Reply

Hi all,

Thanks for your review. We've incorporated the required change and we're good to go!

Regards,

On Thu, Jan 15, 2009 at 1:43 PM, Detlef Ulherr <Detlef dot Ulherr at sun dot com> wrote:
Hi Lalith,

Nothing to add, so fix the copyright and go ahead.

Cheers
Detlef


Thorsten Frueauf wrote:
Hi Lalith et al,


- usr/src/cmd/ql/scripts/bootcluster.sh

  * line 24, the copyright needs to be set to 2009

Otherwise the changes look fine to me.

Thanks for the contribution!

Greets
      Thorsten

Lalith Suresh wrote:
 
Hello everyone,

I recently fixed a very trivial bug (Bug ID 4616225). My sponsor for the same is Tirthankar Das.

The webrev can be viewed at:

http://cr.opensolaris.org/~tirth/webrev_4616225/

I kindly request all of you to review this change and let us know in case there are any complaints within two days so that the changes can be putback ASAP.

Thanks and regards,
Lalith
   

 


--

***************************************************************************** Detlef Ulherr
Staff Engineer                                  Tel: (++49 6103) 752-248
Availability Engineering                        Fax: (++49 6103) 752-167
Sun Microsystems GmbH             Amperestr. 6                                    mailto:detlef dot ulherr at sun dot com
63225 Langen                                    http://www.sun.de/
*****************************************************************************


Sitz der Gesellschaft: Sun Microsystems GmbH, Sonnenallee 1, D-85551
Kirchheim-Heimstetten
Amtsgericht Muenchen: HRB 161028
Geschaeftsfuehrer: Thomas Schroeder, Wolfgang Engels, Dr. Roland Boemer
Vorsitzender des Aufsichtsrates: Martin Haering

*****************************************************************************




--
Lalith Suresh
Department of Computer Engineering
Malaviya National Institute of Technology, Jaipur
+91-9982190365 , lalithsuresh.wordpress.com
_______________________________________________ ha-clusters-discuss mailing list ha-clusters-discuss at opensolaris dot org http://mail.opensolaris.org/mailman/listinfo/ha-clusters-discuss





Terms of Use | Privacy | Trademarks | Copyright Policy | Site Guidelines
Your use of this web site or any of its content or software indicates your agreement to be bound by these Terms of Use.
Copyright © 1995-2005 Sun Microsystems, Inc.