|
|
Heads up: Removal of global kernel lint overrides
Date: Sun, 5 Nov 2006 20:56:08 -0800 (PST)
From: Jerry Gilliam <jg at jurassic dot eng dot sun dot com>
To: onnv-gate at onnv dot eng dot sun dot com
Subject: Heads up: Removal of global kernel lint overrides
The putback of 6470037 does not address any lint warnings.
What it does is to remove all lint warnings overrides at the
uts level, which have been masking a large number of lint
warnings, and instead push all those overrides into per-module
Makefiles. This will permit developers and open solaris contributors
to investigate and address these warnings without needing
to make changes at the greater solaris level. Furthermore
new projects can integrate with fewer lint warnings, and
hopefully fewer undiscovered bugs, than would have been
possible before.
That is, new code can integrate with fewer lint warnings,
but that depends on YOU. Let's try not to proliferate lint
tag overrides from Makefile to Makefile, but instead, let's
work to get rid of these warty little uglies. Any time you
touch a kernel module, take the opportunity to whittle away
at the set of currently needed overrides. What will be most
interesting and beneficial is discovering what actual bugs lie
hidden in all these warnings, of course.
The overrides added to a module's Makefile were tuned to the
specific warnings generated by linting the source comprising
that module. Thus the override tags added to each Makefile
are not identical, although most modules with errors do
include the big 3 most popular: unsigned comparison, ptrdiff
overflow and assign narrow conversion.
Builds have been done with all lint override tags removed,
pointers to this information below. I can continue to
provide such information per-build and arrange to make it
available on perhaps http://onnv.eng or opensolaris.
Lint warnings with all Makefile lint tags removed:
http://tethys.eng/io/lint/onnv_50/sparc
http://tethys.eng/io/lint/onnv_50/i386
-jg
|