OpenSolaris

You are not signed in. Sign in or register.

Flag day: wx(1) cstyle changes

Date: Tue, 22 May 2007 10:22:56 -0700
From: Eric Schrock <eric.schrock at sun dot com>
To: on-all at eng dot sun dot com, onnv-gate at onnv dot eng dot sun dot com
Subject: Flag day: wx(1) cstyle changes

The fix for:

6286359 wx cstyle should include continuation checking by default

Constitutes a flag day for all ON developers and build machine
maintainers.  The default wx(1) cstyle flags have been changed to
include '-c', which performs continuation line checking and was made
usable by 4345989 but never included in the default set of flags.  Build
machines with a local copy of the SUNWonbld tools should update to the
latest packages after tonight's build.  Developers who are on an old
build machine or wish to test the new set of flags today can set
'CSTYLE_FLAGS=-pPc' in their environment prior to running wx(1) to
achieve the same behavior.

For developers, the existing style rules[1] remain the same.  However,
wx(1) and the gatekeepers will be enforcing a stricter set of automatic
checking.  Officially, files must only remain 'cstyle -c' clean if they
are already in this state within the gate, but developers are encouraged
to fix these new warnings when editing otherwise cstyle-clean code.
General cstyle etiquette still applies, so developers should avoid large
scale changes solely to fix cstyle, or changing source from a different
lineage with its own distinct style (open source, old System V code,
etc).  New files must be 'cstyle -pPc' clean, subject to the usual ON
exceptions.

Bugs against cstyle(1) can be filed under 'consolidation/os-net-tools'.

- Eric

[1] http://www.opensolaris.org/os/community/documentation/getting_started_docs/cstyle.ms.pdf

--
Eric Schrock, Solaris Kernel Development       http://blogs.sun.com/eschrock